Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/missing tests #13

Merged
merged 13 commits into from
Oct 28, 2024
Merged

Bug/missing tests #13

merged 13 commits into from
Oct 28, 2024

Conversation

syedhasandigi
Copy link
Contributor

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Bug Fix

Linked tickets

https://digicatapult.atlassian.net/browse/NIDT-36

High level description

Integration/e2e test using npm-pack

Detailed description

integration test that imports @digicatapult/dtdl-parser by using npm-pack and npm install digicatapult-dtdl-parser-*.tgz

Describe alternatives you've considered

npm-link creates a symlink which is not representative of an npm-publish

integration test makes use of npm pack to mimic npm package release
Copy link
Contributor

@mattdean-digicatapult mattdean-digicatapult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a simplification by just importing with ../../. The only thing you might have to watch out for is a linting error

test/integration/package.test.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.depcheckrc Outdated Show resolved Hide resolved
test/integration/package.test.ts Outdated Show resolved Hide resolved
@syedhasandigi syedhasandigi removed the request for review from jonmattgray October 28, 2024 10:11
@syedhasandigi syedhasandigi merged commit ef066de into main Oct 28, 2024
8 checks passed
@syedhasandigi syedhasandigi deleted the bug/missing-tests branch October 28, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants