Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore type safety and options dropdown for data-size & data-color #3042

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

unekinn
Copy link
Contributor

@unekinn unekinn commented Jan 22, 2025

Closes: #3033
Closes: #3034
Relates to: #2943 (closes data-color & data-size part)

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: e81a61c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Preview deployments for this pull request:

Storybook - 23. Jan 2025 - 12:34

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.48% 2958 / 5531
🔵 Statements 53.48% 2958 / 5531
🔵 Functions 85.78% 181 / 211
🔵 Branches 76.73% 521 / 679
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/colors.ts 0% 0% 0% 0%
packages/react/src/sizes.ts 0% 0% 0% 0%
packages/react/src/types.ts 0% 0% 0% 0%
packages/react/src/components/Avatar/Avatar.tsx 73.68% 100% 50% 73.68% 89-99
packages/react/src/components/Combobox/useFormField/useFormField.ts 100% 71.42% 100% 100%
packages/react/src/components/Heading/Heading.tsx 100% 50% 100% 100%
packages/react/src/components/Paragraph/Paragraph.tsx 100% 100% 100% 100%
packages/react/src/components/Spinner/Spinner.tsx 100% 100% 100% 100%
Generated in workflow #1767 for commit e81a61c by the Vitest Coverage Report Action

@unekinn unekinn force-pushed the fix/data-color-and-size-types branch from 0273a92 to 97f89fd Compare January 23, 2025 11:24
@unekinn unekinn force-pushed the fix/data-color-and-size-types branch from 97f89fd to e81a61c Compare January 23, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant