-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: go over react props and jsdoc #3038
Conversation
Preview deployments for this pull request: Storybook - |
🦋 Changeset detectedLatest commit: e21ec0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Burde vi brukt jsdoc for å dokumentere når barn skal være en bestemt sub-component? F.eks forventning at ToggleGroup
sin children
er forventet å være ToggleGroup.Item
eller Tabs
skal ha Tabs.List
og Tabs.Panel
.
Det vil indirekte løst forvirring med Alert
props tabellen #2760
Dette kunne vi løst i egen PR da. Hva tenker du?
Eg tenker me kan ta det i eigen PR ja :) |
resolves #2902
resolves #2932
What has been done:
export *
, and useObject.assign
error
, notvalidation
. TheValidationMessage
can not be changed away fromdanger