Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: blacklist input types for Textfield #2960

Closed
wants to merge 2 commits into from
Closed

feat: blacklist input types for Textfield #2960

wants to merge 2 commits into from

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 8, 2025

resolves #2869

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e1f6afb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Preview deployments for this pull request:

Storybook - 8. Jan 2025 - 08:36

@Barsnes Barsnes marked this pull request as ready for review January 8, 2025 07:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.14% 3198 / 5799
🔵 Statements 55.14% 3198 / 5799
🔵 Functions 85.84% 182 / 212
🔵 Branches 77.31% 525 / 679
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/Textfield/Textfield.tsx 93.87% 70% 100% 93.87% 124-126
Generated in workflow #1502 for commit e1f6afb by the Vitest Coverage Report Action

@Barsnes Barsnes marked this pull request as draft January 8, 2025 07:49
@Barsnes
Copy link
Member Author

Barsnes commented Jan 8, 2025

Since the default type of input types includes string & {}, we are unable to make a blacklist. Closing this PR

@Barsnes Barsnes closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whitelist supported input types in Textfield
1 participant
@Barsnes