Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for PR #2891 to remove border-radius.1 etc more cleanly #2918

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

unekinn
Copy link
Contributor

@unekinn unekinn commented Dec 18, 2024

No description provided.

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: f25304a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Preview deployments for this pull request:

Storybook - 18. Dec 2024 - 19:00

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.17% 3191 / 5783
🔵 Statements 55.17% 3191 / 5783
🔵 Functions 86.6% 181 / 209
🔵 Branches 77.19% 518 / 671
File CoverageNo changed files found.
Generated in workflow #1335 for commit f25304a by the Vitest Coverage Report Action

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. I like the idea of parsing/tweaking tokens before format, much cleaner. Might even need to extract this for other ops, but thats for another time :)

@mimarz mimarz merged commit 2175a20 into feat-cli-border-radius Dec 19, 2024
6 checks passed
@mimarz mimarz deleted the feat-cli-border-radius-une branch December 19, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants