fix: 🐛 Fix missing selector on "default" color #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a bug when building that first color did not get `:root, [data-color-scheme],` selector. This was due to `buildOptions` not being defined. Fixing this for now, but we should rewrite this to avoid hidden globals. All functions should be pure functions, so that its clear for maintaners where dependencies/parameters come from and avoid side-effects.
mimarz
requested review from
Barsnes,
eirikbacker and
unekinn
as code owners
|
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File CoverageNo changed files found. |
Barsnes
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug introduced in #2884, not adding a changeset since we haven't released that change yet.
Bug: When building the first color did not get
:root, [data-color-scheme],selector. This was due tobuildOptionsnot being defined.Fixing this for now, but we should rewrite this to avoid hidden globals. All functions should be pure functions, so that its clear for maintaners where dependencies/parameters come from and avoid side-effects.