Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjustments after relative scaling #2695

Merged
merged 10 commits into from
Oct 30, 2024
Merged

fix: adjustments after relative scaling #2695

merged 10 commits into from
Oct 30, 2024

Conversation

eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Oct 28, 2024 •
edited
Loading

@eirikbacker eirikbacker self-assigned this Oct 28, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 04e3f7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 30. Oct 2024 - 11:45

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.52% 3299 / 5941
🔵 Statements 55.52% 3299 / 5941
🔵 Functions 84.92% 169 / 199
🔵 Branches 74.84% 485 / 648
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/Avatar/Avatar.tsx 76.19% 100% 50% 76.19% 91, 93-101
packages/react/src/components/Label/Label.tsx 100% 100% 100% 100%
packages/react/src/components/Link/Link.tsx 100% 50% 100% 100%
packages/react/src/components/ValidationMessage/ValidationMessage.tsx 100% 100% 100% 100%
packages/react/src/components/form/Checkbox/Checkbox.tsx 100% 66.66% 100% 100%
packages/react/src/components/form/Radio/Radio.tsx 100% 75% 100% 100%
Generated in workflow #654 for commit 04e3f7a by the Vitest Coverage Report Action

@eirikbacker eirikbacker changed the title fix(Label+ValidationMessage): remove old size type fix: adjustments after relative scaling Oct 28, 2024
@eirikbacker eirikbacker marked this pull request as ready for review October 30, 2024 08:29
Barsnes
Barsnes approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📏 📐

@eirikbacker eirikbacker merged commit 42fc24c into next Oct 30, 2024
5 checks passed
@eirikbacker eirikbacker deleted the fix/sizing-adjustments branch October 30, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barsnes Barsnes Barsnes approved these changes

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

@unekinn unekinn Awaiting requested review from unekinn

Assignees

@eirikbacker eirikbacker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sizing adjustments
2 participants
@eirikbacker @Barsnes