Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only run Chromatic on PRs ready for review #2602

Merged
merged 1 commit into from
Oct 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/visual-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,28 @@ name: Visual tests
on:
workflow_dispatch:
pull_request:
branches: [main, next]
types:
# Ensure workflow is run when PR is ready for review
- ready_for_review
# Also enable the default trigger types, for instances when
# the PR is not opened as a draft first
- opened
- reopened
- synchronize

paths:
- .github/workflows/visual-tests.yml
- 'packages/**'
- 'apps/storybook/**'
push:
branches:
- main
- next
branches: [main, next]

jobs:
checks:
name: Build & run visual/interaction tests
runs-on: ubuntu-latest
if: ${{ !github.event.pull_request.draft }}
steps:
- uses: actions/checkout@v4
with:
Expand Down
Loading