Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: input #2550

Merged
merged 30 commits into from
Oct 11, 2024
Merged

feat: input #2550

merged 30 commits into from
Oct 11, 2024

Conversation

eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Oct 1, 2024 •
edited
Loading

@eirikbacker eirikbacker self-assigned this Oct 1, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9663981

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 11. Oct 2024 - 11:11

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 59.42% 3758 / 6324
🔵 Statements 59.42% 3758 / 6324
🔵 Functions 85.93% 165 / 192
🔵 Branches 75.36% 517 / 686
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/form/Input/Input.tsx 85% 100% 50% 85% 47-49
packages/react/src/components/form/Input/InputAffix.tsx 58.33% 100% 0% 58.33% 13-14, 16, 21-22
Generated in workflow #310 for commit 9663981 by the Vitest Coverage Report Action

@eirikbacker eirikbacker marked this pull request as ready for review October 3, 2024 12:50
@eirikbacker eirikbacker mentioned this pull request Oct 4, 2024
Merged
@eirikbacker eirikbacker requested a review from unekinn as a code owner October 8, 2024 10:09
@eirikbacker eirikbacker mentioned this pull request Oct 10, 2024
Closed
3 tasks
mimarz
mimarz approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We did a huddle on some small visual bugs and nitpicks that will be fixed before merging. Approving as work is going to continue on this component in regards to #1943

@eirikbacker eirikbacker merged commit 9099c6c into next Oct 11, 2024
5 checks passed
@eirikbacker eirikbacker deleted the feat/input branch October 11, 2024 09:09
eirikbacker added a commit that referenced this pull request Oct 11, 2024
@eirikbacker
feat: input with select and textbox (#2571)
181ea10 
- Adds `select` and `textarea` to #2550 
- Part of #2311
- Select chevron adjustments are verified by Lasse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

@unekinn unekinn Awaiting requested review from unekinn

Assignees

@eirikbacker eirikbacker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intermediate checkbox should have same width as checked Create Input component
2 participants
@eirikbacker @mimarz