Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set color and background on :root and color modes #2544

Merged
merged 8 commits into from
Oct 1, 2024
Merged

feat: set color and background on :root and color modes #2544

merged 8 commits into from
Oct 1, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Oct 1, 2024 •
edited
Loading

I created a new baseline file, as it seems like our ds-reset file will be removed soon.
I am importing the new file under the layer ds.baseline, but this could also be imported in ds.reset

part of #2454

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1d785c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 1. Oct 2024 - 12:24

@Barsnes Barsnes marked this pull request as ready for review October 1, 2024 09:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 59.58% 3795 / 6369
🔵 Statements 59.58% 3795 / 6369
🔵 Functions 86.63% 162 / 187
🔵 Branches 75.03% 517 / 689
File CoverageNo changed files found.
Generated in workflow #144 for commit 1d785c7 by the Vitest Coverage Report Action

@Barsnes Barsnes changed the title feat: set color on :root and color modes feat: set color and background on :root and color modes Oct 1, 2024
@Barsnes Barsnes marked this pull request as draft October 1, 2024 09:43
@Barsnes Barsnes marked this pull request as ready for review October 1, 2024 10:22
@Barsnes Barsnes merged commit f08ec98 into next Oct 1, 2024
6 checks passed
@Barsnes Barsnes deleted the text/color branch October 1, 2024 11:39
unekinn pushed a commit that referenced this pull request Oct 11, 2024
@Barsnes @unekinn
feat: set color and background on :root and color modes (#2544)
b370cbb 
I created a new baseline file, as it seems like our `ds-reset` file will
be removed soon.
I am importing the new file under the layer `ds.baseline`, but this
could also be imported in `ds.reset`

part of #2454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirikbacker eirikbacker eirikbacker approved these changes

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barsnes @eirikbacker