Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing new color system #2542

Closed
wants to merge 17 commits into from
Closed

Testing new color system #2542

wants to merge 17 commits into from

Conversation

Febakke
Copy link
Member

@Febakke Febakke commented Oct 1, 2024

Test on how we can implement context based colors in Figma

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cd5c81c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 17. Oct 2024 - 13:32

Storefront - 17. Oct 2024 - 13:34

Theme - 11. Oct 2024 - 10:41

@unekinn unekinn self-requested a review as a code owner October 11, 2024 08:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 57.58% 3555 / 6174
🔵 Statements 57.58% 3555 / 6174
🔵 Functions 84.65% 160 / 189
🔵 Branches 76.48% 501 / 655
File CoverageNo changed files found.
Generated in workflow #399 for commit cd5c81c by the Vitest Coverage Report Action

@unekinn unekinn force-pushed the Testing-new-color-system branch from f3ec758 to ff28a2a Compare October 11, 2024 08:43
@Febakke Febakke marked this pull request as draft October 11, 2024 09:03
Febakke and others added 16 commits October 13, 2024 19:36
@Febakke @unekinn
Started setting up structure. Still missing color examples and semant…
91792c7 
…ic token
@Febakke @unekinn
Connected new collection to semantic tokens - still missing new colors
bfa4021
@Febakke @unekinn
Added some example colors
6fad0fe
@Febakke @unekinn
Added set
ab96023
@Febakke @unekinn
Fixed wrong references
3e12fb2
@unekinn
refactor: remove unnecessary conditions in permutateThemes
d8c3824
@unekinn
feat: tokens structure for two "color set" modes (primary/support)
cdfc4e5
@unekinn
feat(cli): build tokens for color-{primary,support} modes
8f25758
@unekinn
wip: some changes necessary to get modes working
7f547b1
@unekinn
wip: don't include --ds-color-{primary,support} in color mode, only i…
7bd893f 
…n category
@unekinn
wip: tokens - replace "accent" with "primary" in semantic layer
96c3810
@unekinn
feat(css): replace --ds-color-accent with --ds-color-primary
0990efe
@unekinn
wip: temporary Button stories to ease color testing
561f852
@unekinn
feat(tokens): move color.{dominant, complimentary, accent} to semanti…
a929f3d 
…c layer
@unekinn
fixup tokens - set color.focus.outer back to color.accent
03082c6
@unekinn
feat(cli): only output semantic color variables to css
d6895b7
@unekinn unekinn force-pushed the Testing-new-color-system branch from 58ada36 to d6895b7 Compare October 14, 2024 13:29
@unekinn unekinn force-pushed the Testing-new-color-system branch from e51513e to cd5c81c Compare October 17, 2024 11:30
@mimarz mimarz closed this Nov 1, 2024
@mimarz mimarz deleted the Testing-new-color-system branch November 1, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@unekinn unekinn Awaiting requested review from unekinn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Febakke @mimarz @unekinn