Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Skeleton): size of variant text #2510

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Conversation

eirikbacker
Copy link
Contributor

Fixes #2471

@eirikbacker eirikbacker self-assigned this Sep 25, 2024
Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: b4b781f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Preview deployments for this pull request:

Storybook - 26. Sep 2024 - 13:45

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 60.14% 3937 / 6546
🔵 Statements 60.14% 3937 / 6546
🔵 Functions 85.86% 164 / 191
🔵 Branches 75.14% 535 / 712
File CoverageNo changed files found.
Generated in workflow #71

@Barsnes
Copy link
Member

Barsnes commented Sep 25, 2024

It still does not match how it was before. How close should we get to that?
I feel your PR gives to little space between lines of text. Looks like line-height is included here, which maybe it should not be? 🤔

NEW // OLD
image

@eirikbacker
Copy link
Contributor Author

eirikbacker commented Sep 25, 2024

It still does not match how it was before. How close should we get to that? I feel your PR gives to little space between lines of text. Looks like line-height is included here, which maybe it should not be? 🤔

Good catch @Barsnes 🙌 Nothing to do with line-height, but the fact that it was previously scaled to 60% height, so updated now to match this 👍

Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☠️

@eirikbacker eirikbacker merged commit 3d2b88f into next Sep 26, 2024
6 checks passed
@eirikbacker eirikbacker deleted the fix/skeleton-text-size branch September 26, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Skeleton no longer has correct text height
2 participants