-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: postcss composes directive #2410
Conversation
|
Preview deployments for this pull request: 📖 Storybook See all deployments at https://dev.designsystemet.no |
Coverage Report
File CoverageNo changed files found. |
Preview deploymentsTheme |
How do we want to handle multiple applies?
|
Do we have to fix the build for individual files? When the rule is not found it just keeps the |
The individual files are not processed at all by postcss as you can see, so I'm a bit unsure why we add them to dist? |
I suggest the #3 approach - no problem making the others work, but it will require more code in your little plugin, and one apply class per line seems a bit cleaner too? |
After a short meeting between me and @eirikbacker we decided to tweak the This will make it more clear and also work for single component css files having it applied correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update the description and pr title with new directive name :)
Bra jobba! 👏 |
composes
, but custom implementation forpostcss