Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storefront): Fix stylings #1837

Merged
merged 8 commits into from
Apr 18, 2024
Merged

chore(storefront): Fix stylings #1837

merged 8 commits into from
Apr 18, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Apr 16, 2024 •
edited
Loading

  • Copies over normalize.css and adds it to a layer.
  • Sorts layers.
  • Removes a lot of !important that are not needed anymore.
  • Adds accessible title to GH and Figma links.
  • Size updates from feedback

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 16. Apr 2024 - 15:37 (Norwegian time)

🖥 Storefront 16. Apr 2024 - 15:38 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review April 16, 2024 13:35
@Barsnes Barsnes requested a review from mimarz as a code owner April 16, 2024 13:35
@Barsnes Barsnes changed the title chore(storefront): Fix css specificity chore(storefront): Fix stylings Apr 18, 2024
mimarz
mimarz approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Barsnes Barsnes merged commit 9555a92 into main Apr 18, 2024
8 checks passed
@Barsnes Barsnes deleted the storefront/updates branch April 18, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barsnes @mimarz