Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(css): Create utils.css #1811

Merged
merged 4 commits into from
Apr 15, 2024
Merged

refactor(css): Create utils.css #1811

merged 4 commits into from
Apr 15, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Apr 12, 2024

Resolves #1810

Unsure about the title here, since this will be added to both packages.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 12, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 15. Apr 2024 - 15:29 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review April 12, 2024 07:57
@Barsnes Barsnes requested a review from mimarz as a code owner April 12, 2024 07:57
mimarz
mimarz requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names are quite long 🤔

I dont think names need to include "utilities", as this won't scale well with other utilities we aim to provide and its not needed to distinct.

Suggest we keep it simple and use something like;
fds-sr-only and fds-focus

@mimarz
Copy link
Collaborator

mimarz commented Apr 15, 2024

I suggest the title is changed to refactor as it doesn't introduce anything new for our users, its mostly internal refactor.

@Barsnes Barsnes changed the title feat(css): Create utilities.css refactor(css): Create utilities.css Apr 15, 2024
@Barsnes Barsnes requested a review from mimarz April 15, 2024 13:21
@Barsnes Barsnes changed the title refactor(css): Create utilities.css refactor(css): Create utils.css Apr 15, 2024
mimarz
mimarz approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Barsnes Barsnes merged commit 2aec769 into main Apr 15, 2024
5 checks passed
@Barsnes Barsnes deleted the css/utilities branch April 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create utilities.css
2 participants
@Barsnes @mimarz