Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 💚 Fix yarn warnings about dependencies #1774

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Apr 8, 2024

Fix as many as possible warnings when running yarn

Before:
image

After:
image

Removed also @storybook/addon-mdx-gfm

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Preview deployments for this pull request:

📖 Storybook 8. Apr 2024 - 12:56 (Norwegian time)

🖥 Storefront 8. Apr 2024 - 12:56 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mimarz mimarz marked this pull request as ready for review April 8, 2024 10:54
@mimarz mimarz requested a review from Barsnes as a code owner April 8, 2024 10:54
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting the same amount of warnings as you 👍🏻
image

@mimarz mimarz merged commit 4b6cafc into main Apr 8, 2024
8 checks passed
@mimarz mimarz deleted the chore/fix-yarn-warnings branch April 8, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants