Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tokens): some of the tokens on semantic levels was using hex code #1386

Merged
merged 4 commits into from
Jan 16, 2024
Merged

chore(tokens): some of the tokens on semantic levels was using hex code #1386

merged 4 commits into from
Jan 16, 2024

Conversation

mrosvik
Copy link
Member

@mrosvik mrosvik commented Jan 15, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 16. Jan 2024 - 14:45 (Norwegian time)

🖥 Storefront 16. Jan 2024 - 14:46 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mrosvik mrosvik marked this pull request as ready for review January 15, 2024 13:01
@mimarz
Copy link
Collaborator

mimarz commented Jan 16, 2024

I see semantic-text-danger-hover went from a darker color to lighter red color. Was this intended? @mrosvik

@mimarz mimarz closed this Jan 16, 2024
@mimarz mimarz reopened this Jan 16, 2024
@mrosvik
Copy link
Member Author

mrosvik commented Jan 16, 2024

I see semantic-text-danger-hover went from a darker color to lighter red color. Was this intended? @mrosvik

That was not intended! Thanks! Fixed :)

mimarz
mimarz approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@mimarz mimarz merged commit 87f07ca into main Jan 16, 2024
@mimarz mimarz deleted the tokens/color-missing-link branch January 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@Thunear Thunear Awaiting requested review from Thunear

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrosvik @mimarz