Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton no longer has correct text height #2471

Closed
mimarz opened this issue Sep 20, 2024 · 5 comments · Fixed by #2510
Closed

Skeleton no longer has correct text height #2471

mimarz opened this issue Sep 20, 2024 · 5 comments · Fixed by #2510
Assignees
Labels
🐛 bug Something isn't working css @digdir/designsystemet-css react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented Sep 20, 2024

@mimarz mimarz converted this from a draft issue Sep 20, 2024
@mimarz mimarz added react @digdir/designsystemet-react css @digdir/designsystemet-css 🐛 bug Something isn't working labels Sep 20, 2024
@Barsnes
Copy link
Member

Barsnes commented Sep 20, 2024

Is this a duplicate of #2468?

@mimarz
Copy link
Collaborator Author

mimarz commented Sep 20, 2024

Is this a duplicate of #2468?

Looks like, although that issue wasn't very descriptive of the problem? 🙈

@Barsnes
Copy link
Member

Barsnes commented Sep 20, 2024

Is this a duplicate of #2468?

Looks like, although that issue wasn't very descriptive of the problem? 🙈

I agree, but let's delete one of them and update the remaining issue with what we need 🗡️

@eirikbacker
Copy link
Contributor

The solution we had before was to scale with vertical scale 60% which by accident worked with the font we have, but there is no guarantee for that, and the rounding was squished. However, it makes the elements the right height, and a 1:1 match with the content itself may not be possible with today's CSS text size units, so perhaps we should rather draw the content with ::before so the rounding is not squished, but we can still achieved 60% height? ☺️

@mimarz
Copy link
Collaborator Author

mimarz commented Sep 20, 2024

Lets try that :)

@eirikbacker eirikbacker self-assigned this Sep 25, 2024
@eirikbacker eirikbacker moved this from 📄 Todo to 👀 Ready for review in Team Design System Sep 25, 2024
eirikbacker added a commit that referenced this issue Sep 26, 2024
Fixes #2471

---------

Co-authored-by: Tobias Barsnes <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working css @digdir/designsystemet-css react @digdir/designsystemet-react
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants