-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeleton
no longer has correct text height
#2471
Comments
Is this a duplicate of #2468? |
Looks like, although that issue wasn't very descriptive of the problem? 🙈 |
I agree, but let's delete one of them and update the remaining issue with what we need 🗡️ |
The solution we had before was to scale with vertical scale 60% which by accident worked with the font we have, but there is no guarantee for that, and the rounding was squished. However, it makes the elements the right height, and a 1:1 match with the content itself may not be possible with today's CSS text size units, so perhaps we should rather draw the content with ::before so the rounding is not squished, but we can still achieved 60% height? |
Lets try that :) |
Fixes #2471 --------- Co-authored-by: Tobias Barsnes <[email protected]>
Currently:
https://next.storybook.designsystemet.no/?path=/docs/komponenter-loaders-skeleton--docs#text
Before:
https://storybook.designsystemet.no/?path=/docs/komponenter-loaders-skeleton--docs#text
The text was updated successfully, but these errors were encountered: