chore: fix urls in preview workflows (#2430)

digdir · Sep 17, 2024 · fdc61bd · fdc61bd
1 parent 3451704
commit fdc61bd
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 21 deletions.
diff --git a/...workflows/cleanup-preview-deployments.yml → .github/workflows/preview-cleanup.yml b/...workflows/cleanup-preview-deployments.yml → .github/workflows/preview-cleanup.yml
@@ -5,10 +5,9 @@ on:
 
 env:
   VERCEL_TEAM: ${{ secrets.VERCEL_TEAM }}
-  VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
-  VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID_STOREFRONT }}
-  STORYBOOK_URL: storybook-pr-${{ github.event.number }}.dev.designsystemet.no
-  STOREFRONT_URL: storefront-pr-${{ github.event.number }}.dev.designsystemet.no
+  STORYBOOK_URL: pr-${{ github.event.number }}.storybook.designsystemet.no
+  STOREFRONT_URL: pr-${{ github.event.number }}.designsystemet.no
+  THEME_URL: pr-${{ github.event.number }}.theme.designsystemet.no
   ALIASES:
 
 jobs:
@@ -33,3 +32,7 @@ jobs:
       - name: Remove Storefront alias if it exists
         if: contains(env.ALIASES, env.STOREFRONT_URL)
         run: vercel alias rm --yes --token=${{ secrets.VERCEL_TOKEN }} --scope=${{ secrets.VERCEL_TEAM }} ${{ env.STOREFRONT_URL }}
+
+      - name: Remove Theme alias if it exists
+        if: contains(env.ALIASES, env.THEME_URL)
+        run: vercel alias rm --yes --token=${{ secrets.VERCEL_TOKEN }} --scope=${{ secrets.VERCEL_TEAM }} ${{ env.THEME_URL }}
diff --git a/.github/workflows/create-preview-comment.yml → .github/workflows/preview-comment.yml b/.github/workflows/create-preview-comment.yml → .github/workflows/preview-comment.yml
diff --git a/.github/workflows/preview-storefront.yml b/.github/workflows/preview-storefront.yml
@@ -1,4 +1,4 @@
-name: Deploy Storefront PR
+name: Deploy Storefront Preview
 env:
   VERCEL_TEAM: ${{ secrets.VERCEL_TEAM }}
   VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
@@ -42,7 +42,7 @@ jobs:
         run: echo "url=$(vercel deploy --prebuilt --token=${{ secrets.VERCEL_TOKEN }})" >> $GITHUB_OUTPUT
 
       - name: Set Vercel alias
-        run: vercel alias --token=${{ secrets.VERCEL_TOKEN }} --scope=${{ secrets.VERCEL_TEAM }} set ${{ steps.deploy.outputs.url }} storefront-pr-${{ env.PR_NUMBER }}.dev.designsystemet.no
+        run: vercel alias --token=${{ secrets.VERCEL_TOKEN }} --scope=${{ secrets.VERCEL_TEAM }} set ${{ steps.deploy.outputs.url }} pr-${{ env.PR_NUMBER }}.designsystemet.no
 
       - name: Find Preview Comment
         uses: peter-evans/find-comment@v2
@@ -60,14 +60,14 @@ jobs:
         id: regex-storybook
         with:
           text: ${{ steps.fc.outputs.comment-body }}
-          regex: '\[Storybook\]\((https:\/\/[^)]+)\) `[^`]+`'
+          regex: '\[Storybook\]\((https:\/\/[^)]+)\).*'
 
       - name: Find Theme deployment
         uses: actions-ecosystem/action-regex-match@v2
         id: regex-theme
         with:
           text: ${{ steps.fc.outputs.comment-body }}
-          regex: '\[Theme\]\((https:\/\/[^)]+)\)'
+          regex: '\[Theme\]\((https:\/\/[^)]+)\).*'
 
       - name: Get current time in CEST
         uses: josStorer/get-current-time@v2
@@ -82,12 +82,11 @@ jobs:
           issue-number: ${{ env.PR_NUMBER }}
           comment-id: ${{ steps.fc.outputs.comment-id }}
           edit-mode: replace
-          reactions: rocket, eyes
           body: |
             **Preview deployments for this pull request:**
 
             ${{ steps.regex-storybook.outputs.match }}
 
-            [Storefront](https://storefront-pr-${{ env.PR_NUMBER }}.dev.designsystemet.no) `${{ steps.current-time.outputs.formattedTime }} (Norwegian time)`
+            [Storefront](https://pr-${{ env.PR_NUMBER }}.designsystemet.no) - `${{ steps.current-time.outputs.formattedTime }}`
 
             ${{ steps.regex-theme.outputs.match }}
diff --git a/.github/workflows/preview-storybook.yml b/.github/workflows/preview-storybook.yml
@@ -1,4 +1,4 @@
-name: Deploy Storybook PR
+name: Deploy Storybook Preview
 env:
   VERCEL_TEAM: ${{ secrets.VERCEL_TEAM }}
   VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
@@ -44,7 +44,7 @@ jobs:
         run: echo "url=$(vercel deploy --prebuilt --token=${{ secrets.VERCEL_TOKEN }})" >> $GITHUB_OUTPUT
 
       - name: Set Vercel alias
-        run: vercel alias --token=${{ secrets.VERCEL_TOKEN }} --scope=${{ secrets.VERCEL_TEAM }} set ${{ steps.deploy.outputs.url }} storybook-pr-${{ env.PR_NUMBER }}.dev.designsystemet.no
+        run: vercel alias --token=${{ secrets.VERCEL_TOKEN }} --scope=${{ secrets.VERCEL_TEAM }} set ${{ steps.deploy.outputs.url }} pr-${{ env.PR_NUMBER }}.storybook.designsystemet.no
 
       - name: Find Preview Comment
         uses: peter-evans/find-comment@v2
@@ -62,14 +62,14 @@ jobs:
         id: regex-storefront
         with:
           text: ${{ steps.fc.outputs.comment-body }}
-          regex: '\[Storefront\]\((https:\/\/[^)]+)\) `[^`]+`'
+          regex: '\[Storefront\]\((https:\/\/[^)]+)\).*'
 
       - name: Find Theme deployment
         uses: actions-ecosystem/action-regex-match@v2
         id: regex-theme
         with:
           text: ${{ steps.fc.outputs.comment-body }}
-          regex: '\[Theme\]\((https:\/\/[^)]+)\)'
+          regex: '\[Theme\]\((https:\/\/[^)]+)\).*'
 
       - name: Get current time in CEST
         uses: josStorer/get-current-time@v2
@@ -84,11 +84,10 @@ jobs:
           issue-number: ${{ env.PR_NUMBER }}
           comment-id: ${{ steps.fc.outputs.comment-id }}
           edit-mode: replace
-          reactions: rocket, eyes
           body: |
             **Preview deployments for this pull request:**
 
-            [Storybook](https://storybook-pr-${{ env.PR_NUMBER }}.dev.designsystemet.no) `${{ steps.current-time.outputs.formattedTime }} (Norwegian time)`
+            [Storybook](https://pr-${{ env.PR_NUMBER }}.storybook.designsystemet.no) - `${{ steps.current-time.outputs.formattedTime }}`
 
             ${{ steps.regex-storefront.outputs.match }}
 

diff --git a/.github/workflows/preview-theme.yml b/.github/workflows/preview-theme.yml
@@ -1,4 +1,4 @@
-name: Deploy Theme PR
+name: Deploy Theme Preview
 env:
   VERCEL_TEAM: ${{ secrets.VERCEL_TEAM }}
   VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
@@ -60,14 +60,14 @@ jobs:
         id: regex-storybook
         with:
           text: ${{ steps.fc.outputs.comment-body }}
-          regex: '\[Storybook\]\((https:\/\/[^)]+)\) `[^`]+`'
+          regex: '\[Storybook\]\((https:\/\/[^)]+)\).*'
 
       - name: Find Storefront deployment
         uses: actions-ecosystem/action-regex-match@v2
         id: regex-storefront
         with:
           text: ${{ steps.fc.outputs.comment-body }}
-          regex: '\[Storefront\]\((https:\/\/[^)]+)\) `[^`]+`'
+          regex: '\[Storefront\]\((https:\/\/[^)]+)\).*'
 
       - name: Get current time in CEST
         uses: josStorer/get-current-time@v2
@@ -82,12 +82,11 @@ jobs:
           issue-number: ${{ env.PR_NUMBER }}
           comment-id: ${{ steps.fc.outputs.comment-id }}
           edit-mode: replace
-          reactions: rocket, eyes
           body: |
             **Preview deployments for this pull request:**
 
             ${{ steps.regex-storybook.outputs.match }}
 
             ${{ steps.regex-storefront.outputs.match }}
 
-            [Theme](https://pr-${{ env.PR_NUMBER }}.theme.designsystemet.no) `${{ steps.current-time.outputs.formattedTime }} (Norwegian time)`
+            [Theme](https://pr-${{ env.PR_NUMBER }}.theme.designsystemet.no) - `${{ steps.current-time.outputs.formattedTime }}`