-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Bitbucket Cloud and Server #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a great PR! It has one big problem which is that it adds a new GitAnchorType BRANCH
. I think that's a bad idea, but I'm happy to merge it anyway.
But! We should merge Bitbucket support without BRANCH
support. Then, after that has been merged, I'd be happy to take a new PR which adds BRANCH
support. I just created a new issue for mutable branch support in #24.
If you delete support for BRANCH
, it will be quick and easy to get this merged. From there, it's also easy to close out #24 if you still want to.
I made a few tweaks:
If you're okay with these changes, I'm ready to merge and release. |
lgtm! |
Released in |
filenameSafe
now removes query parameters and appends file name to the end of the link to preserve its original file extension.