Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-think group handling #90

Merged
merged 5 commits into from
Mar 15, 2023
Merged

Re-think group handling #90

merged 5 commits into from
Mar 15, 2023

Conversation

dieghernan
Copy link
Owner

@dieghernan dieghernan commented Mar 15, 2023

This would make easier to implement #88

Improve #82 #84

@dieghernan dieghernan added enhancement New feature or request 🛠dplyr Issues related with dplyr methods ⇝ spatvector Related with SpatVector labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 98.07% and project coverage change: -0.09 ⚠️

Comparison is base (0f18f67) 99.53% compared to head (e47d5b0) 99.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   99.53%   99.44%   -0.09%     
==========================================
  Files          42       42              
  Lines        2152     2172      +20     
==========================================
+ Hits         2142     2160      +18     
- Misses         10       12       +2     
Impacted Files Coverage Δ
R/group-by-SpatVector.R 95.00% <87.50%> (-5.00%) ⬇️
R/bind-rows-SpatVector.R 98.57% <95.00%> (-1.43%) ⬇️
R/as_spatvector.R 100.00% <100.00%> (ø)
R/as_tibble-Spat.R 100.00% <100.00%> (ø)
R/count-tally-SpatVector.R 100.00% <100.00%> (ø)
R/group-data-SpatVector.R 100.00% <100.00%> (ø)
R/grouped-SpatVector.R 100.00% <100.00%> (ø)
R/summarise-SpatVector.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dieghernan dieghernan marked this pull request as ready for review March 15, 2023 17:57
@dieghernan dieghernan merged commit 3c76cfd into main Mar 15, 2023
@dieghernan dieghernan deleted the newgroups branch May 3, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠dplyr Issues related with dplyr methods enhancement New feature or request ⇝ spatvector Related with SpatVector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant