Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cypress Tests #522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Cypress Tests #522

wants to merge 2 commits into from

Conversation

rblaine95
Copy link
Contributor

  • Increase the cy.wait for Keycloak redirect from 600ms to 1200ms
  • Add a cy.wait(2000) to the beginning of the Opportunity creation forms

@rblaine95 rblaine95 added bug Something isn't working chore Chores, housekeeping, etc labels Feb 26, 2024
@rblaine95 rblaine95 self-assigned this Feb 26, 2024
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from b0d693b to e02af9c Compare February 27, 2024 09:22
@rblaine95 rblaine95 marked this pull request as ready for review February 27, 2024 09:34
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch 2 times, most recently from bca6b49 to 0dc57e0 Compare February 27, 2024 10:37
@@ -29,7 +29,8 @@ export const login = (username: string, password: string) => {
// });
// });
cy.get('button[id="btnSignIn"]').should("exist").click();
cy.wait(6000);
// Something is causing Next -> Keycloak load time to be long
cy.wait(12000);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, but this wasn't previously the case (around the time of the SQL>POSTGRES move)

unfortunately, the more tests we add, the more these timeouts will compound, adding several minutes to the total test run-time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is that SQL -> Postgres shouldn't be causing this.
Keycloak was always on Postgres.
As far as I can replicate, this only happens via Cypress (Chromium and Electron).
If you spin it up on your local, it's quick.

@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 0dc57e0 to 05f1e03 Compare March 5, 2024 12:27
@rblaine95 rblaine95 changed the title [wip] Fix Cypress Tests Fix Cypress Tests Mar 5, 2024
@rblaine95
Copy link
Contributor Author

@jasondicker, until the Cypress tests pass, merging this will block all future PRs/deployments

@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 05f1e03 to 8436f09 Compare March 15, 2024 08:39
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 8436f09 to 0008ef2 Compare March 28, 2024 13:11
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch 2 times, most recently from c8079f9 to a5df898 Compare April 4, 2024 10:19
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from a5df898 to 9e6da1b Compare April 9, 2024 09:17
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 9e6da1b to 7a5845c Compare April 10, 2024 12:23
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 7a5845c to 4e2bd73 Compare April 23, 2024 08:12
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch 3 times, most recently from 9ad2be6 to 18e3b17 Compare April 24, 2024 13:20
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 18e3b17 to b235e26 Compare May 3, 2024 10:11
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch 2 times, most recently from c07e448 to 469e90a Compare May 7, 2024 11:33
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch 2 times, most recently from dc74c00 to 62c090f Compare May 8, 2024 09:00
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 62c090f to 4d3a972 Compare May 16, 2024 08:36
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 4d3a972 to 426c247 Compare June 4, 2024 12:54
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
yoma ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 9:55am

@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 426c247 to a34d41a Compare June 11, 2024 08:09
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from a34d41a to a4fb184 Compare July 9, 2024 06:49
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from a4fb184 to 9c82c88 Compare July 11, 2024 13:26
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 9c82c88 to 83fe112 Compare July 23, 2024 06:58
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 83fe112 to bea1fc3 Compare August 8, 2024 07:55
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from bea1fc3 to 66e82be Compare August 26, 2024 09:32
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 66e82be to 37a3df1 Compare September 3, 2024 08:04
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 37a3df1 to 4215146 Compare September 17, 2024 12:00
@rblaine95 rblaine95 force-pushed the chore/fix-cypress-tests branch from 4215146 to 7ec9da7 Compare October 30, 2024 10:11
rblaine95 and others added 2 commits December 2, 2024 11:54
* Increase the `cy.wait` for Keycloak redirect from 600ms to 1200ms
* Add a `cy.wait(2000)` to the beginning of the Opportunity creation
  forms

Fix ZLTO Reward field in Cypress

More fixes

Remove unneeded sleep

Don't enable Credential Issuance

Wait 1s before/after entering opportunity keywords
Bumps [cypress](https://github.com/cypress-io/cypress) from 13.7.0 to 13.16.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md)
- [Commits](cypress-io/cypress@v13.7.0...v13.16.0)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Chores, housekeeping, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants