-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cypress Tests #522
base: master
Are you sure you want to change the base?
Fix Cypress Tests #522
Conversation
b0d693b
to
e02af9c
Compare
bca6b49
to
0dc57e0
Compare
@@ -29,7 +29,8 @@ export const login = (username: string, password: string) => { | |||
// }); | |||
// }); | |||
cy.get('button[id="btnSignIn"]').should("exist").click(); | |||
cy.wait(6000); | |||
// Something is causing Next -> Keycloak load time to be long | |||
cy.wait(12000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, but this wasn't previously the case (around the time of the SQL>POSTGRES move)
unfortunately, the more tests we add, the more these timeouts will compound, adding several minutes to the total test run-time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is that SQL -> Postgres shouldn't be causing this.
Keycloak was always on Postgres.
As far as I can replicate, this only happens via Cypress (Chromium and Electron).
If you spin it up on your local, it's quick.
0dc57e0
to
05f1e03
Compare
@jasondicker, until the Cypress tests pass, merging this will block all future PRs/deployments |
05f1e03
to
8436f09
Compare
8436f09
to
0008ef2
Compare
c8079f9
to
a5df898
Compare
a5df898
to
9e6da1b
Compare
9e6da1b
to
7a5845c
Compare
7a5845c
to
4e2bd73
Compare
9ad2be6
to
18e3b17
Compare
18e3b17
to
b235e26
Compare
c07e448
to
469e90a
Compare
dc74c00
to
62c090f
Compare
62c090f
to
4d3a972
Compare
4d3a972
to
426c247
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
426c247
to
a34d41a
Compare
a34d41a
to
a4fb184
Compare
a4fb184
to
9c82c88
Compare
9c82c88
to
83fe112
Compare
83fe112
to
bea1fc3
Compare
bea1fc3
to
66e82be
Compare
66e82be
to
37a3df1
Compare
37a3df1
to
4215146
Compare
4215146
to
7ec9da7
Compare
* Increase the `cy.wait` for Keycloak redirect from 600ms to 1200ms * Add a `cy.wait(2000)` to the beginning of the Opportunity creation forms Fix ZLTO Reward field in Cypress More fixes Remove unneeded sleep Don't enable Credential Issuance Wait 1s before/after entering opportunity keywords
Bumps [cypress](https://github.com/cypress-io/cypress) from 13.7.0 to 13.16.0. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v13.7.0...v13.16.0) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
7ec9da7
to
553ee4f
Compare
cy.wait
for Keycloak redirect from 600ms to 1200mscy.wait(2000)
to the beginning of the Opportunity creation forms