-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️Waypoint re-subscribe #1217
⚡️Waypoint re-subscribe #1217
Conversation
afe043e
to
1c23193
Compare
2a858b6
to
d3e14f7
Compare
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just the one line to be edited
waypoint/services/nats_service.py
Outdated
@@ -184,7 +193,7 @@ async def event_generator( | |||
logger.debug("Successfully resubscribed to NATS.") | |||
|
|||
except Exception as e: # pylint: disable=W0718 | |||
logger.exception("Unexpected error in event generator: {}", e) | |||
logger.exception("Unexpected error in event generator: {}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: {}
Quality Gate passedIssues Measures |
K8s Test Coverage
|
K8s Regression Test Coverage
|
Add retry logic to subscribe function.
Also resubscribe on TimeoutError.
Update unit tests