-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atom Support #47
Atom Support #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go over standarts for Atom a bit later, here's a couple of comments regarding the structure
Nice PR, as I said, I'll go over spec for Atom a bit later, however, thanks for contributing, if any of the parts from my comments are unclear or you don't have time to implement them - ping me, I'll help answering or coding |
Also, this should fix tests --- a/tests/samples/atom.json
+++ b/tests/samples/atom.json
@@ -63,7 +63,7 @@
},
"published": {
"attributes": {},
- "content": "2003-12-13 08:29:29-04:00"
+ "content": "2003-12-13T08:29:29-04:00"
},
"rights": null,
"source": null,
@@ -126,7 +126,7 @@
},
"updated": {
"attributes": {},
- "content": "2005-07-31 12:29:29+00:00"
+ "content": "2005-07-31T12:29:29Z"
}
}
}, |
Alright, tests are working now as well. Let me know what I need to change for the Atom spec as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, know this is a lot of comments, but it's just due to us not having a clear plan of development before implementation. I'll try to raise a PR for your branch in your repo so we can merge it faster
@ddkasa Whoops, accidentally commited straight to your branch, I apologize, wanted to create a branch to show you the diff with the fixes. Please check out the diff and let me know what you think |
There can be a case where system timezone setting may break datetime.fromtimestamp if supplying a timezone like `...Z` Pydantic module already has it, so re-using it (as it should've been before)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMK if this seems good to you and I'll merge
Looks good to me. Initially had a bunch of sub-models setup, but decided to remove before submitting to keep it more simple. Regarding removing the |
@ddkasa there is a way to backport even when removing, but I agree on using model.rss.blah.blah |
Made the changes as discussed in #46.
I made some directory changes to accommodate the new Atom model. Otherwise kept to the same code style as used for the RSS model. Works when testing with the sample Atom XML provided, but can't seem to get the tests working as the JSON dump formatting is giving me problems.
Let me know what you need to change before merging or how to approach the testing.