fix: allow input field to have zero value #1647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1647--dhis2-ui.netlify.app |
flaminic
changed the title
amcgee
requested changes
Dec 4, 2024
Comment on lines
69
to
75
| value={ | ||
| value === null || | ||
| value === undefined || | ||
| Number.isNaN(value) | ||
| ? '' | ||
| : value | ||
| } |
There was a problem hiding this comment.
Could this just use a nullish coalescing operator? Are we also trying to handle NaN falsy values or just trying to make sure 0 can be passed?
Suggested change
| value={ | |
| value === null || | |
| value === undefined || | |
| Number.isNaN(value) | |
| ? '' | |
| : value | |
| } | |
| value={value ?? ''} |
There was a problem hiding this comment.
Yes, i was not sure here. I doubt NaN is ever going to be passed as a value, but I thought maybe safer to keep the previous behaviour for everything that is not 0, -0 or other forms of 0? But happy to change it as well. Do you think ?? would be better?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes changing number fields with value 0 to having value ""
Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots
supporting text