Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC --- feat(transfer): use native single-/multi selects #1556

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mohammer5
Copy link
Contributor

@Mohammer5 Mohammer5 commented Jul 24, 2024

With those minimal changes, the following stories work/don't work:

  • ✅ Single Selection
  • ✅ Multiple
  • ✅ Header
  • ✅ Options Footer
  • ✅ Filtered
  • ✅ Filtered Picked
  • ✅ Filtered Placeholder
  • ❌ Custom List Options (very easy / trivial; needs rework of the story)
  • ❌ Individual Custom Option (very easy / trivial; needs rework of the story)
  • ✅ Custom Button Text
  • ✅ Source Empty Placeholder
  • ✅ Picked Empty Component
  • ✅ Reordering
  • ❌ Increased Options Height (very easy / trivial; but has the risk of not working cross-browser)
  • ✅ Different Widths
  • ✅ Custom Filtering With Filter Input
  • ✅ Custom Filtering Without Filter Input
  • ❌ Infinite Loading (the only issue that's not trivial)
  • ✅ Loading Source
  • ✅ Loading Picked
  • ✅ RTL

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jul 24, 2024

🚀 Deployed on https://pr-1556--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify July 24, 2024 10:41 Inactive
@Mohammer5 Mohammer5 force-pushed the PoC-transfer-native-select branch from 9efe801 to ee209d0 Compare July 24, 2024 10:46
@dhis2-bot dhis2-bot temporarily deployed to netlify July 24, 2024 10:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants