Added more check and conversions for tracked entity instances.

dhis2 · Oct 8, 2018 · c3efc1c · c3efc1c
1 parent 3b56688
commit c3efc1c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/...his2/fhir/adapter/prototype/dhis/tracker/trackedentity/impl/TrackedEntityServiceImpl.java b/...his2/fhir/adapter/prototype/dhis/tracker/trackedentity/impl/TrackedEntityServiceImpl.java
@@ -64,6 +64,8 @@ public class TrackedEntityServiceImpl implements TrackedEntityService
     protected static final String FIND_BY_ATTR_VALUE_URI = "/trackedEntityInstances.json?" +
         "trackedEntityType={typeId}&ouMode=ACCESSIBLE&filter={attrId}:EQ:{attrValue}&pageSize={maxResult}";
 
+    protected static final int MAX_RESERVE_RETRIES = 10;
+
     private final RestTemplate restTemplate;
 
     @Autowired
@@ -77,8 +79,28 @@ public TrackedEntityServiceImpl( @Nonnull @Qualifier( "userDhis2RestTemplate" )
     public TrackedEntityInstance createNewInstance( @Nonnull TrackedEntityType type )
     {
         final TrackedEntityInstance instance = new TrackedEntityInstance( type.getId(), null, true );
-        type.getAttributes().stream().filter( a -> a.getAttribute().isGenerated() ).forEach( a -> instance.getAttributes().add(
-            new TrackedEntityAttributeValue( a.getAttributeId(), getReservedValue( a.getAttributeId() ) ) ) );
+        type.getAttributes().stream().filter( a -> a.getAttribute().isGenerated() ).forEach( a -> {
+            boolean retry = true;
+            for ( int i = 0; (i < MAX_RESERVE_RETRIES) && retry; i++ )
+            {
+                final String reservedValue = getReservedValue( a.getAttributeId() );
+                retry = false;
+                switch ( a.getValueType() )
+                {
+                    case INTEGER:
+                    case INTEGER_NEGATIVE:
+                    case INTEGER_POSITIVE:
+                    case INTEGER_ZERO_OR_POSITIVE:
+                    case NUMBER:
+                        retry = reservedValue.startsWith( "0" );
+                        break;
+                }
+                if ( !retry )
+                {
+                    instance.getAttributes().add( new TrackedEntityAttributeValue( a.getAttributeId(), reservedValue ) );
+                }
+            }
+        } );
         return instance;
     }
 

diff --git a/src/main/java/org/dhis2/fhir/adapter/prototype/geo/StringToLocationConverter.java b/src/main/java/org/dhis2/fhir/adapter/prototype/geo/StringToLocationConverter.java
@@ -38,7 +38,7 @@
 
 public class StringToLocationConverter extends TypedConverter<String, Location>
 {
-    private final Pattern locationPattern = Pattern.compile( "\\[\\s*([\\d.]+)\\s*,\\s*([\\d.]+)\\s*\\]" );
+    private final Pattern locationPattern = Pattern.compile( "\\s*\\[\\s*([+\\-\\d.eE]+)\\s*,\\s*([+\\-\\d.eE]+)\\s*]\\s*" );
 
     public StringToLocationConverter()
     {