-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove old TEA change log [DHIS2-18477] #19388
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always get confused when we talk about audit.
Is TrackedEntityAudit really used by someone? Maybe we can ask one more time, hopefully last time, to Morten to be sure it is needed.
It seems to me that it is just auditing when something it is DELETED and randomly auditing when something is READ.
@@ -36,7 +36,6 @@ | |||
/** | |||
* @author Abyot Asalefew Gizaw [email protected] | |||
*/ | |||
@Deprecated(since = "2.42", forRemoval = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not deprecate, should be moved outside deprecated
package?
@@ -246,76 +243,6 @@ public RootNode getAggregateDataValueAudit( | |||
return rootNode; | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add this removal somewhere in the release-notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do, it's my next and hopefully final step when it comes to change logs.
I don't know if someone is using the audit feature, I'll contact Morten to clarify that. Until then, I think it should not be deprecated. |
Quality Gate passedIssues Measures |
This PR removes the old TEA change log endpoint, service, and store.
While working on this, I realized a few things:
plainValue
for TEA instead ofvalue
to ensure that if the value is encrypted, the encrypted value doesn’t end up in the change log table.DELETE
change log entry on behalf of the duplicated TE. That TE was then deleted along with all its related change logs, including the one just created. I removed the step where thatDELETE
change log entry is created.TrackedEntityAuditService
andTrackedEntityAuditStore
should not be deprecated. This was probably due to confusion caused by the inconsistent naming between "change log" and "audit."DefaultTrackedEntityAttributeValueService.updateTrackedEntityAttributeValue
was only used in tests, so I am removing it as well.