-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add not-null constraint for column trackedentitytypeid in trackedentity table [DHIS2-15066] #19112
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are having discussion about the approach here (that is the same for organisationunitid column in event and enrollment) and we are trying to avoid to create dummy data that are likely entering the DB and never being deleted.
I think we should fix this the same way in all the places where we found it.
As soon as we have a strategy we should go back to this PR and see what we should do.
...rvice-tracker/src/test/java/org/hisp/dhis/tracker/deduplication/DeduplicationHelperTest.java
Outdated
Show resolved
Hide resolved
...rvice-tracker/src/test/java/org/hisp/dhis/tracker/deduplication/DeduplicationHelperTest.java
Outdated
Show resolved
Hide resolved
femaleA.setTrackedEntityType(trackedEntityType); | ||
femaleB.setTrackedEntityType(trackedEntityType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setTrackedEntityType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
.../dhis/tracker/imports/validation/validator/trackedentity/SecurityOwnershipValidatorTest.java
Show resolved
Hide resolved
@@ -311,7 +312,8 @@ private TrackedEntity teWithDeleteEnrollments() { | |||
Enrollment enrollment = new Enrollment(); | |||
enrollment.setDeleted(true); | |||
|
|||
TrackedEntity trackedEntity = createTrackedEntity(organisationUnit); | |||
TrackedEntity trackedEntity = | |||
createTrackedEntity(organisationUnit, createTrackedEntityType('B')); | |||
trackedEntity.setUid(TE_ID.getValue()); | |||
trackedEntity.setEnrollments(Sets.newHashSet(enrollment)); | |||
trackedEntity.setTrackedEntityType(trackedEntityType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setTrackedEntityType
...org/hisp/dhis/tracker/imports/validation/validator/event/SecurityOwnershipValidatorTest.java
Show resolved
Hide resolved
@@ -389,7 +389,8 @@ void verifyValidationFailsForEnrollmentDeletionAndUserWithoutTrackedEntityTypeRe | |||
} | |||
|
|||
private TrackedEntity teWithNoEnrollments() { | |||
TrackedEntity trackedEntity = createTrackedEntity(organisationUnit); | |||
TrackedEntity trackedEntity = | |||
createTrackedEntity(organisationUnit, createTrackedEntityType('C')); | |||
trackedEntity.setUid(TE_ID.getValue()); | |||
trackedEntity.setEnrollments(Sets.newHashSet()); | |||
trackedEntity.setTrackedEntityType(trackedEntityType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setTrackedEntityType
@@ -263,7 +263,7 @@ private TrackedEntityType trackedEntityType(String uid, char uniqueChar) { | |||
} | |||
|
|||
private TrackedEntity trackedEntity(UID uid, TrackedEntityType type, OrganisationUnit orgUnit) { | |||
TrackedEntity te = createTrackedEntity(orgUnit); | |||
TrackedEntity te = createTrackedEntity(orgUnit, createTrackedEntityType('R')); | |||
te.setUid(uid.getValue()); | |||
te.setTrackedEntityType(type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setTrackedEntityType
WHERE trackedentitytypeid IS NULL | ||
) | ||
LOOP | ||
UPDATE trackedentity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we shouldn't update any record.
We should only apply the constraint.
The we can suggest such a script in the migration notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a lower possibility of errors if we handle the task ourselves rather than leaving it to the user. Therefore, we should aim to complete as much of the migration process as possible and leave as little as necessary for the user to manage.
SELECT COUNT(*) INTO inconsistent_records_count FROM trackedentity WHERE trackedentitytypeid IS NULL; | ||
|
||
IF inconsistent_records_count = 0 THEN | ||
ALTER TABLE trackedentity ALTER COLUMN trackedentitytypeid SET NOT NULL; | ||
ELSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is a little bit redundant.
You can apply the constraint and if it fails then you raise the exception.
Before we merge this, can we make sure we update the dev db snapshot to have this "fixing scripts" run? So that we don't break dev again for Phil to fix later. |
Quality Gate passedIssues Measures |
DHIS2-15066
createTrackedEntity
method signature inTestBase.java
to make sure user provide a non-nullTrackedEntityType
toTrackedEntity
.