Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new dashboard plugin architecture #3082

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Jun 4, 2024

Part of the fix for DHIS2-17268

Requires dhis2/analytics#1672


Key features

  1. use shared dashboard plugin wrapper

Description

Generic components for plugins are available in app-platform and app-runtime.
Analytics apps are currently having the same components replicated in each repo, a shared dashboard plugin wrapper has been added in analytics.


Known issues

  • an infinite loop happened and this seems to solve it, I'm not sure why and if this is a proper solution.

Screenshots

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 4, 2024

🚀 Deployed on https://pr-3082.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify June 4, 2024 13:52 Inactive
@edoardo edoardo changed the title Refactor/use platform plugin components refactor: use shared dashboard plugin wrapper Jun 4, 2024
@edoardo edoardo requested a review from KaiVandivier June 5, 2024 13:05
@dhis2-bot dhis2-bot temporarily deployed to netlify June 6, 2024 13:09 Inactive
@jenniferarnesen jenniferarnesen changed the base branch from dev to master June 21, 2024 09:48
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch 2 times, most recently from ac182a8 to 4b736b2 Compare July 1, 2024 14:05
@dhis2-bot dhis2-bot temporarily deployed to netlify July 1, 2024 14:09 Inactive
@edoardo edoardo marked this pull request as ready for review July 3, 2024 09:57
@dhis2-bot dhis2-bot temporarily deployed to netlify July 3, 2024 09:58 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 1, 2024 13:46 Inactive
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch from 6822d49 to 86d232d Compare August 2, 2024 13:31
@dhis2-bot dhis2-bot temporarily deployed to netlify August 2, 2024 13:34 Inactive
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch from 86d232d to 39740ef Compare August 5, 2024 09:05
@dhis2-bot dhis2-bot temporarily deployed to netlify August 5, 2024 09:08 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 16, 2024 08:25 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 19, 2024 09:30 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 21, 2024 14:16 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 11, 2024 11:51 Inactive
@edoardo edoardo changed the title refactor: use shared dashboard plugin wrapper feat: support new dashboard plugin architecture Nov 11, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify November 11, 2024 15:12 Inactive
src/PluginWrapper.js Outdated Show resolved Hide resolved
@edoardo edoardo added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Nov 12, 2024
Copy link

cypress bot commented Nov 12, 2024

Data Visualizer App    Run #2975

Run Properties:  status check failed Failed #2975  •  git commit 42cbc15180 ℹ️: Merge ba1e82df89206c9d9a5e1444ec6df662d69ba5f2 into 2415c4ab9b3a7f8f986a8d6b8e73...
Project Data Visualizer App
Branch Review refactor/use-platform-plugin-components
Run status status check failed Failed #2975
Run duration 16m 20s
Commit git commit 42cbc15180 ℹ️: Merge ba1e82df89206c9d9a5e1444ec6df662d69ba5f2 into 2415c4ab9b3a7f8f986a8d6b8e73...
Committer Edoardo Sabadelli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 37
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 2
Tests that passed  Passing 693
View all changes introduced in this branch ↗︎

Tests for review

Failed  dimensions/orgUnit.cy.js • 9 failed tests • e2e-chrome-parallel-2.40-1

View Output Video

Test Artifacts
Org unit dimension > selects a district level org unit - Bo Test Replay Screenshots Video
Org unit dimension > selects a chiefdom level org unit - Biriwa in Bombali Test Replay Screenshots Video
Org unit dimension > deselects Bo and Biriwa Test Replay Screenshots Video
Org unit dimension > selects a level - District Test Replay Screenshots Video
Org unit dimension > deselects District Test Replay Screenshots Video
Org unit dimension > selects a group - Eastern Area Test Replay Screenshots Video
Org unit dimension > deselects Eastern Area Test Replay Screenshots Video
Org unit dimension > selects a user org unit - 'User sub-units' Test Replay Screenshots Video
Org unit dimension > deselects 'User sub-units' Test Replay Screenshots Video
Failed  dimensions/orgUnit.cy.js • 9 failed tests • e2e-chrome-parallel-2.41-1

View Output Video

Test Artifacts
Org unit dimension > selects a district level org unit - Bo Test Replay Screenshots Video
Org unit dimension > selects a chiefdom level org unit - Biriwa in Bombali Test Replay Screenshots Video
Org unit dimension > deselects Bo and Biriwa Test Replay Screenshots Video
Org unit dimension > selects a level - District Test Replay Screenshots Video
Org unit dimension > deselects District Test Replay Screenshots Video
Org unit dimension > selects a group - Eastern Area Test Replay Screenshots Video
Org unit dimension > deselects Eastern Area Test Replay Screenshots Video
Org unit dimension > selects a user org unit - 'User sub-units' Test Replay Screenshots Video
Org unit dimension > deselects 'User sub-units' Test Replay Screenshots Video
Failed  save.cy.js • 2 failed tests • e2e-chrome-parallel-2.40-2

View Output Video

Test Artifacts
saving an AO > "save" and "save as" for a saved AO created by you Test Replay Screenshots Video
saving an AO > "save" a copied AO created by others works after editing Test Replay Screenshots Video
Failed  dimensions/data.cy.js • 2 failed tests • e2e-chrome-parallel-2.40-4

View Output Video

Test Artifacts
Data dimension > displays Event data items correctly Test Replay Screenshots Video
Data dimension > displays Program indicators correctly Test Replay Screenshots Video
Failed  options/legend.cy.js • 11 failed tests • e2e-chrome-parallel-2.41-3

View Output Video

Test Artifacts
Options - Legend > applies different styles of legend to a Gauge chart Test Replay Screenshots Video
Options - Legend > applies different styles of legend to a Stacked Column chart Test Replay Screenshots Video
Options - Legend > applies different styles of legend to a Pivot table Test Replay Screenshots Video
Options - Legend > applies the legend when vis type is changed from Pivot table to Gauge Test Replay Screenshots Video
Options - Legend > applies the legend when vis type is changed from Pivot table to Single value Test Replay Screenshots Video
Options - Legend > applies the legend key settings when vis type changes: Column -> Pivot table -> Gauge -> Single value Test Replay Screenshots Video
Options - Legend > does not apply non-applicable options when Column switched to Area Test Replay Screenshots Video
Options - Legend > does not enable legend options for Line chart Test Replay Screenshots Video
Options - Legend > changes legend from per data item to fixed strategy for Column chart Test Replay Screenshots Video
Options - Legend > only applies legend for charts where data is not on series when legend display strategy is fixed Test Replay Screenshots Video
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

Flakiness  dimensions/data.cy.js • 1 flaky test • e2e-chrome-parallel-2.40-4

View Output Video

Test Artifacts
Data dimension > displays Indicators correctly Test Replay Screenshots Video
Flakiness  options/limitValues.cy.js • 1 flaky test • e2e-chrome-parallel-2.40-4

View Output Video

Test Artifacts
limit values > min value only display correctly Test Replay Screenshots Video
Flakiness  interpretations.cy.js • 1 flaky test • e2e-chrome-parallel-2.40-5

View Output Video

Test Artifacts
Interpretations > opens the interpretations modal on a saved AO Test Replay Screenshots Video
Flakiness  dimensions/period.cy.js • 1 flaky test • e2e-chrome-parallel-2.41-2

View Output Video

Test Artifacts
Period dimension > using period settings - hidden monthly > navigates to the start page Test Replay Screenshots Video

@dhis2-bot dhis2-bot temporarily deployed to netlify November 15, 2024 13:47 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 18, 2024 12:57 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 4, 2024 10:48 Inactive
This fixes the issue of DV plugins getting "stuck" in showing an error
even after the cause is removed.
If a dashboard filter is applied and causes a DV visualization to not
have data, an error is shown in the plugin.
When the filter was removed, the error was still shown.
@dhis2-bot dhis2-bot temporarily deployed to netlify December 6, 2024 13:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants