Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove d2 #3023

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

fix: remove d2 #3023

wants to merge 7 commits into from

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Apr 18, 2024

Implements DHIS2-XXXX


Key features

  1. prepare to get rid of d2 entirely

Description

This branch has changes to remove the need for d2.
There is still one place where d2 is needed and we don't have an alternative at the moment, the user data store.


TODO

  • figure out how to use the user data store without d2
  • lots of regression testing
  • fix tests, particularly the App.js tests, but before touching them we should figure out how we want to test, what should
    be tested in Cypress and what in unit tests
  • look for and clean up more code not needed
  • see if it's possible to avoid fetching all user authorities to check for the ALL, do we really need the isSuperuser flag?
  • fix DimensionsPanel.spec.js: figure out how to mock the cachedDataQuery / provider (tests are skipped)

Known issues

  • the user data store is used to store the visualization object when switching visualization from DV to Maps. Currently it relies on d2 as it's using some classes defined in that package.
  • now that with this PR DV uses the app service data for getting/setting the current AO in the user data store, Maps should be updated in order to read the AO from the same key, since the app service stores the key under settings. Fixed here.

Screenshots

Not very meaningful but this is the app running on this branch:
Screenshot 2022-07-21 at 15 16 34

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Apr 18, 2024

@dhis2-bot dhis2-bot temporarily deployed to netlify April 18, 2024 07:50 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify April 18, 2024 07:57 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify April 25, 2024 10:58 Inactive
@jenniferarnesen jenniferarnesen changed the base branch from dev to master June 21, 2024 09:49
@dhis2-bot dhis2-bot temporarily deployed to netlify July 5, 2024 08:56 Inactive
The confirm screen when leaving the page didn't work with functional
components.
@dhis2-bot dhis2-bot temporarily deployed to netlify July 8, 2024 13:17 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 8, 2024 13:50 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 9, 2024 08:30 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 16, 2024 12:29 Inactive
@edoardo edoardo mentioned this pull request Dec 5, 2024
7 tasks
@edoardo edoardo added the On hold label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants