-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alerts provider): make plugin props optional #1384
base: master
Are you sure you want to change the base?
Conversation
children, | ||
plugin = false, | ||
parentAlertsAdd = undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's certainly not necessary to provide these default values, not sure what our team thinks is good good practice here?
I like seeing default values, but that's personal / preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also want to add a default false
for showAlertsInPlugin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments for your consideration, but looks good 🙏
children, | ||
plugin = false, | ||
parentAlertsAdd = undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also want to add a default false
for showAlertsInPlugin
?
children: React.ReactNode | ||
plugin?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin
should actually always be defined as long as you are using an up-to-date version of app-platform (https://github.com/dhis2/app-platform/blob/master/shell/src/App.js#L43). I'm not sure if there's a scenario where we want to mark it as an optional in case you're trying to resolve to a higher-version of app-runtime while using an older version of app-platform?
Quality Gate passedIssues Measures |
While moving the instance manager FE from CRA to Vite, I encountered one type issue in this repository:
The
AlertsProvider
's plugin props aren't optional