Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clipboard permission in plugin iframe #1382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: clipboard permission in plugin iframe #1382

wants to merge 2 commits into from

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Jun 21, 2024 •
edited
Loading

This is part of https://dhis2.atlassian.net/issues/UX-136

Key features

Specifies that iframe generated by wrapper should have clipboard write access (in order for plugin error boundary to allow copying error to clipboard)

Checklist

  • Have written Documentation
    • This is an internal change, so I don't think we want to document.
  • Has tests coverage
    • No 🙃. We need test coverage on plugins generally (I guess as part of becoming non-experimental)

@tomzemp tomzemp mentioned this pull request Jun 21, 2024
Merged
@tomzemp tomzemp requested review from KaiVandivier and a team June 21, 2024 11:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiVandivier KaiVandivier KaiVandivier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomzemp @KaiVandivier