fix(OpenFileDialog): use table toolbars #1526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
force-pushed
the
open-dialog-design
branch
from
8e4ff21 to
b0c001b
Compare
This reverts commit b0c001b.
|
@cooper-joe I tried out the changes and found that the modal does a brief height change when paging, which results in a jumpy effect. Before: Screen.Recording.2024-11-04.at.14.28.50.mov](url) After Screen.Recording.2024-11-04.at.14.29.35.mov |
|
@cooper-joe can you take another look at this one? |
|
@jenniferarnesen I don't think the jumping modal height is related to these changes. It seems to happen for only the first time a page is changed (e.g. the first 1->2 and the first 2->3). Screen recording from current master branch with the same issue: Kapture.2024-12-10.at.09.45.06.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key features
DataTableToolbarwrapper components.UIversion to get input size fixes.Screenshots
Before:
After: