Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenFileDialog): use table toolbars #1526

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Jun 28, 2023

Key features

  1. Place filtering and pagination in DataTableToolbar wrapper components.
  2. Bump UI version to get input size fixes.

Screenshots

Before:

image

After:

image

Copy link
Member

@edoardo edoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenniferarnesen
Copy link
Collaborator

@cooper-joe I tried out the changes and found that the modal does a brief height change when paging, which results in a jumpy effect.

Before:
[

Screen.Recording.2024-11-04.at.14.28.50.mov

](url)

After

Screen.Recording.2024-11-04.at.14.29.35.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants