-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OpenFileDialog): use table toolbars #1526
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8e4ff21
to
b0c001b
Compare
This reverts commit b0c001b.
@cooper-joe I tried out the changes and found that the modal does a brief height change when paging, which results in a jumpy effect. Before: Screen.Recording.2024-11-04.at.14.28.50.mov](url) After Screen.Recording.2024-11-04.at.14.29.35.mov |
@cooper-joe can you take another look at this one? |
@jenniferarnesen I don't think the jumping modal height is related to these changes. It seems to happen for only the first time a page is changed (e.g. the first 1->2 and the first 2->3). Screen recording from current master branch with the same issue: Kapture.2024-12-10.at.09.45.06.mp4 |
Key features
DataTableToolbar
wrapper components.UI
version to get input size fixes.Screenshots
Before:
After: