-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embeddedrespondfactory threading issue #16
base: master
Are you sure you want to change the base?
Embeddedrespondfactory threading issue #16
Conversation
…stom status codes and the other goodies of Reply
…ositories to cerberus.local
… in the flashcache
…tifactory * create VelocityEngineProvider to create just one engine for all template compilations
…oject. I know I had this in here before
…ethod interceptors (DecorateWidget change)
…somehow missed this earlier)
…eTuple, (2) that EmbedWidget has only one EmbeddedRespondFactory and (3) the EmbeddedRespondFactory was keeping a final StringBuilderRespond object to pass as the delegate to the factoried EmbeddedRespond. So, if two requests come in for the same page, they end up sharing a StringBuilderRespond
Holy crap, this should never happen--thanks let me chase it down! |
This pull request is messed up because I branched from the wrong spot. sorry. The next one will be better :) |
Hehe, OK, thanks! |
Do you have a fix for this yet? |
I never got this pull request cleaned up. The Fix is changing one file -- I did not see any negative side effects to instantiating a new new -James On Fri, Apr 20, 2012 at 6:57 PM, dhanji <
|
When Guice Stage.PRODUCTION, and more than one request was being served by the same PageTuple, they ended up sharing the same StringBuilderRespond -- kaboom!
so I moved the private final Respond respond = new StringBuilderRespond(new Object()); declaration of EmbeddedRespondFactory into the get method. Hopefully this pull request reflects that one small change to EmbeddedRespondFactory.