Refactoring code and adding more coverage

dgsudharsan · Mar 25, 2024 · 2ccadf4 · 2ccadf4
1 parent 32a195a
commit 2ccadf4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/orchagent/portsorch.cpp b/orchagent/portsorch.cpp
@@ -7739,7 +7739,7 @@ void PortsOrch::refreshPortStatus()
                 updateDbPortOperSpeed(port, 0);
             }
             sai_port_fec_mode_t fec_mode;
-            string fec_str;
+            string fec_str = "N/A";
             if (oper_fec_sup && getPortOperFec(port, fec_mode))
             {
                 if (!m_portHlpr.fecToStr(fec_str, fec_mode))
@@ -7748,12 +7748,8 @@ void PortsOrch::refreshPortStatus()
                                    static_cast<std::int32_t>(fec_mode), port.m_alias.c_str());
                     fec_str = "N/A";
                 }
-                updateDbPortOperFec(port,fec_str);
-            }
-            else
-            {
-                updateDbPortOperFec(port, "N/A");
             }
+            updateDbPortOperFec(port,fec_str);
         }
     }
 }

diff --git a/tests/mock_tests/portsorch_ut.cpp b/tests/mock_tests/portsorch_ut.cpp
@@ -1301,6 +1301,20 @@ namespace portsorch_test
             }
         }
         ASSERT_TRUE(fec_found == true);
+
+        /*Mock an invalid fec mode with high value*/
+        _sai_port_fec_mode = 100;
+        gPortsOrch->refreshPortStatus();
+        statePortTable.get("Ethernet0", values);
+        fec_found = false;
+        for (auto &valueTuple : values)
+        {
+            if (fvField(valueTuple) == "fec")
+            {
+                fec_found = true;
+                ASSERT_TRUE(fvValue(valueTuple) == "N/A");
+            }
+        }
         mock_port_fec_modes = old_mock_port_fec_modes;
         _unhook_sai_port_api();
     }