This repository has been archived by the owner on May 21, 2022. It is now read-only.
Native support for key rotation in verifications #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
changed the title
fishy
force-pushed
the
key-rotation
branch
4 times, most recently
from
320829c to
50e63e0
Compare
Add native support for key rotation for ES*, HS*, RS*, and PS* verifications. In those SigningMethod's Verify implementations, also allow the key to be the type of the slice of the supported key type, so that the caller can implement the KeyFunc to return all the accepted keys together to support key rotation. While key rotation verification can be done on the callers' side without this change, this change provides better performance because: - When trying the next key, the steps before actually using the key do not need to be performed again. - If a verification process failed for non-key reasons (for example, because it's already expired), it saves the effort to try the next key.
|
Here is an example of how it's used: reddit/baseplate.go@0bd3365 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add native support for key rotation for ES*, HS*, RS*, and PS*
verifications.
In those SigningMethod's Verify implementations, also allow the key to
be the type of the slice of the supported key type, so that the caller
can implement the KeyFunc to return all the accepted keys together to
support key rotation.
While key rotation verification can be done on the callers' side without
this change, this change provides better performance because:
When trying the next key, the steps before actually using the key do
not need to be performed again.
If a verification process failed for non-key reasons (for example,
because it's already expired), it saves the effort to try the next
key.