Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other e2e encryption types #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

moparisthebest
Copy link

@moparisthebest moparisthebest commented Jun 13, 2016

This adds support for OMEMO, XEP-27 PGP, and XEP-373 OX PGP. I made each configurable so you could set up a server that only allowed OMEMO for instance.

Arguably you'd rename this to mod_e2e or something, but I didn't go that far. :)

@herbsmn
Copy link

herbsmn commented Sep 7, 2016

Hey @iNPUTmice, do you have any thoughts on this?

@micah
Copy link

micah commented Sep 7, 2016

this looks good!

@herbsmn
Copy link

herbsmn commented Sep 7, 2016

thoughts @dgoulet?

@elijh
Copy link

elijh commented Sep 7, 2016

This is awesome! Could you also allow messages for MUC to pass through if mandatory is enabled and the message is OMEMO or OpenPGP?

@elijh
Copy link

elijh commented Sep 7, 2016

To be more clear, there appears to be a bug in this patch:

This patch will break the 'mixed' mode (require OTR except for MUC). In our test, this patch will make encryption required for MUC, even when running in 'mixed' mode.

@moparisthebest
Copy link
Author

This doesn't break mixed mode, all it does is additionally allow messages through if they are OMEMO or PGP. You might want to re-think your mixed mode though, because OMEMO/PGP can work in MUCs as well.

@elijh
Copy link

elijh commented Sep 8, 2016

We thought that it would allow mixed mode too. But when we installed this patch with mixed mode on, all the MUCs stopped working.

Yes, we would like to drop mixed mode in the future, once more people have transitioned to omemo, but for now we want to be able to require encryption for user to user chats and make it optional for muc. One problem is the omemo group chats only work under specific circumstances (private groups, everyone in the group subscribed to status updates from everyone else).

@moparisthebest
Copy link
Author

You can see the change, I literally added allows for omemo/pgp, and didn't change any mixed mode logic. It works as it did before, are you sure you set it right?

@Neustradamus
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants