eclab: Rename params for consistency between mpr and mpt
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
PeterKraus
force-pushed
the
rename_params
branch
from
dcf8f49
to
9c60dea
Compare
This was referenced Oct 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The params in
techniques.pyare renamed to ensuremprandmpthave the same parameters. This means themprparameters will include the typos present inmptfiles!Tests are now checking for consistency between
mprandmptfiles in the following params:I Range* vs.unit *The
param_mapis significantly extended, implementing most of #191.Also fixed parsing of parameters for several previously broken techniques in
mprfiles.