Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflection.cutoff_prune() #90

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Conversation

PeterKraus
Copy link
Contributor

The normalisation in dgpost.transform.reflection.cutoff_prune() was odd. Prior to the fix it was:

n = x - (min / (max / min))

After this fix it is:

n = (x - min) / (max - min)

i.e. always between 0 and 1. Not sure what I was smoking at the time.

@PeterKraus PeterKraus added bug Something isn't working backport labels Feb 22, 2024
@PeterKraus PeterKraus merged commit b3b4e6e into dgbowl:master Feb 22, 2024
9 checks passed
@PeterKraus PeterKraus deleted the fix_cutoff_prune branch February 22, 2024 15:47
PeterKraus added a commit that referenced this pull request Feb 28, 2024
* Fix normalisation in prune_cutoff

* Fix reflection tests

* Fix realworld tests

* Freeze xarray so tests pass

* Urgh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant