Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the creatorUid to ANDROID-CloudTAK-${user.email} when creating missions #443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brian7704
Copy link

Changes the creatorUid when creating missions to match the UID used elsewhere in CloudTAK. This solves an error I was getting while updating OpenTAKServer to work with CloudTAK.

@ingalls
Copy link
Member

ingalls commented Dec 11, 2024

@brian7704 This is great, quick Q - Is the expectation that UID is just consistent but nothing is locked to the format of the value itself?

Context is that the ANDROID- prefix was something I thought was required 2 years ago when I started reverse engineering some of this stuff and I now realize isn't. It probably should just got dropped in favour of a pure uuid or CLOUDTAK-<uuid>

Thoughts?

@ingalls
Copy link
Member

ingalls commented Dec 11, 2024

In the near future I also need to checkout the ramifications of

TKS-871 validate client uid to prevent spoofing

In the recent 5.3 release

@brian7704
Copy link
Author

@brian7704 This is great, quick Q - Is the expectation that UID is just consistent but nothing is locked to the format of the value itself?

Context is that the ANDROID- prefix was something I thought was required 2 years ago when I started reverse engineering some of this stuff and I now realize isn't. It probably should just got dropped in favour of a pure uuid or CLOUDTAK-<uuid>

Thoughts?

I believe that's correct. It's just expected to be unique and consistent but to my knowledge there's no format that it needs to adhere to. I know that iTAK uses just a UUID and WinTAK uses a format like this S-1-5-21-3880475707-799676908-474682855-1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants