Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Rendering (Stage 1) #266

Merged
merged 25 commits into from
Aug 8, 2024
Merged

Conditional Rendering (Stage 1) #266

merged 25 commits into from
Aug 8, 2024

Conversation

ingalls
Copy link
Member

@ingalls ingalls commented Aug 8, 2024

Context

Our last big update was diff based rendering which sped up rendering tremendously as only features that came through the socket would be upserted. This is great until you run into a layer like the lightening layer where large numbers of essentially unchanging features come through the socket and are rendered.

This PR introduces the following:

  • Introduces a COT class that implements the Feature type and serves as a container for helper fns
  • Introduces an as_rendered() fn which only builds a feature with the minimum properties needed to render it on the map

TODO:

  • MultiSelect doesn't differentiate between COT and Feat

Ref: #264

@ingalls ingalls changed the title Conditional Rendering Conditional Rendering (Stage 1) Aug 8, 2024
@ingalls ingalls merged commit 5e32f86 into main Aug 8, 2024
7 checks passed
@ingalls ingalls deleted the efficient-update branch August 8, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant