Add Name Properties

dfpc-coe · Mar 11, 2024 · 9d7d293 · 9d7d293
1 parent 576fd26
commit 9d7d293
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/cloudformation/lib/api.js b/cloudformation/lib/api.js
@@ -25,7 +25,8 @@ export default {
         ELBSecurityGroup: {
             Type : 'AWS::EC2::SecurityGroup',
             Properties : {
-                GroupDescription: cf.join('-', [cf.stackName, 'elb-sg']),
+                GroupName: cf.join('-', [cf.stackName, 'elb-sg']),
+                GroupDescription: 'Allow 443 and 80 Access to ELB',
                 SecurityGroupIngress: [{
                     CidrIp: '0.0.0.0/0',
                     IpProtocol: 'tcp',
@@ -377,7 +378,8 @@ export default {
         ServiceSecurityGroup: {
             Type: 'AWS::EC2::SecurityGroup',
             Properties: {
-                GroupDescription: cf.join('-', [cf.stackName, 'ec2-sg']),
+                GroupName: cf.join('-', [cf.stackName, 'ec2-sg']),
+                GroupDescription: 'Allow access to docker port 5000',
                 VpcId: cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-vpc'])),
                 SecurityGroupIngress: [{
                     CidrIp: '0.0.0.0/0',

diff --git a/cloudformation/lib/batch.js b/cloudformation/lib/batch.js
@@ -135,6 +135,7 @@ export default {
             Type: 'AWS::EC2::SecurityGroup',
             Properties: {
                 VpcId: cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-vpc'])),
+                GroupName: cf.join([cf.stackName, '-batch']),
                 GroupDescription: cf.join([cf.stackName, ' Batch Security Group']),
                 SecurityGroupIngress: []
             }

diff --git a/cloudformation/lib/db.js b/cloudformation/lib/db.js
@@ -88,7 +88,8 @@ export default {
         DBSubnet: {
             Type: 'AWS::RDS::DBSubnetGroup',
             Properties: {
-                DBSubnetGroupDescription: cf.join('-', [cf.stackName, 'rds-subnets']),
+                DBSubnetGroupName: cf.join('-', [cf.stackName, 'rds-subnets']),
+                DBSubnetGroupDescription: 'Group Private Subnets',
                 SubnetIds: [
                     cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-subnet-private-a'])),
                     cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-subnet-private-b']))
@@ -98,7 +99,8 @@ export default {
         DBVPCSecurityGroup: {
             Type: 'AWS::EC2::SecurityGroup',
             Properties: {
-                GroupDescription: cf.join('-', [cf.stackName, 'rds-sg']),
+                GroupName: cf.join('-', [cf.stackName, 'rds-sg']),
+                GroupDescription: 'Allow RDS Database Ingress',
                 VpcId: cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-vpc'])),
                 SecurityGroupIngress: [{
                     IpProtocol: '-1',