Upgrade DFX to 0.22.0 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
reviewed
Sep 19, 2024
mraszyk
reviewed
Sep 19, 2024
That would only apply to the first candidate path |
max-dfinity
approved these changes
Sep 19, 2024
mraszyk
reviewed
Sep 19, 2024
| REGISTRY_FOUND=$(find "$BASE_PATH" -type d -name ic_registry_local_store 2>/dev/null) | ||
|
|
||
| if [ $(echo "$REGISTRY_FOUND" | wc -l) -gt 1 ]; then | ||
| echo "Error: Multiple ic_registry_local_store directories found" |
There was a problem hiding this comment.
Suggested change
| echo "Error: Multiple ic_registry_local_store directories found" | |
| echo "Error: Multiple ic_registry_local_store directories found; please start your local replica using `dfx start --clean`" |
There was a problem hiding this comment.
Sorry, I thought it wouldn't let me merge until I resolved this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading DFX from v0.19.0 to v0.22.0, there was a change in where DFX stores the registry info, so I added a new place for sns-testing to look for it in. I tried it on my mac and on CI and it seems to work.
I left the other places it looked in case any of them are used in some circumstances, but I don't think they are for this version of DFX. (Perhaps they would be useful if someone wanted to use an old version of DFX though.) The dfx start docs say that: