chore: bump SNS aggregator version and configure it to be fast #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterga
reviewed
May 24, 2024
| fi | ||
|
|
||
| ${DFX} canister install sns_aggregator --network "${NETWORK}" --wasm nns-dapp/out/sns_aggregator.wasm | ||
| if [ ! -z "${SNS_AGGREGATOR_RELEASE:-}" ] |
There was a problem hiding this comment.
Why do we need the if statement?
There was a problem hiding this comment.
There already used to be an if-statement
if [ ! -z "${NNS_DAPP_RELEASE:-}" ]
covering both the NNS dapp and the SNS aggregator. Since this PR introduces a separate env var for the SNS aggregator, I had to add a new if statement. Now regarding the motivation: the reason is to allow expert people to put their own wasms into nns-dapp/out to install a custom version of the canisters.
aterga
reviewed
May 24, 2024
aterga
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the SNS aggregator version and configures it to be fast. This makes the NNS frontend dapp launchpad update quickly once an NNS proposal to create an SNS is executed.