Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: warn when the 'canister_ids.json' file is first generated for persistent networks. #4058

Merged
merged 5 commits into from
Jan 9, 2025
Merged

chore: warn when the 'canister_ids.json' file is first generated for persistent networks. #4058

merged 5 commits into from
Jan 9, 2025

Conversation

vincent-dfinity
Copy link
Contributor

@vincent-dfinity vincent-dfinity commented Jan 8, 2025 •
edited
Loading

Description

Warn when the 'canister_ids.json' file is first generated for persistent networks.

Fixes # (issue)

SDK-1911

How Has This Been Tested?

Added e2e tests.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vincent-dfinity vincent-dfinity requested a review from a team as a code owner January 8, 2025 05:41
@vincent-dfinity vincent-dfinity enabled auto-merge (squash) January 9, 2025 08:48
@vincent-dfinity vincent-dfinity merged commit 55f23c2 into master Jan 9, 2025
298 checks passed
@vincent-dfinity vincent-dfinity deleted the vincent/SDK-1911 branch January 9, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sesi200 sesi200 sesi200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-dfinity @sesi200