fix: update-replica.sh for commit starting with digit #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the update-replica.sh script to also support commits starting with a digit. Previously, the expression
\1$SHA\2where$SHAgets substituted for3e24396441e4c7380928d4e8b4ccff7de77d0e7e(for instance) would be interpreted as\13followed bye24396441e4c7380928d4e8b4ccff7de77d0e7eand\2instead of\1followed bye24396441e4c7380928d4e8b4ccff7de77d0e7eand\2.The new perl command has been tested manually on Ubuntu 24.04.1 LTS and perl5 (revision 5 version 38 subversion 2).