fix: make asset canister reserve space when saving to stable storage #4036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the asset canister estimate the size of the data to be serialized to stable memory, and reserve that much space for the ValueSerializer's buffer.
The portal fails to upgrade from dfx 0.22.0 with an opaque
Canister trapped: unreachable error
.This turns out to be the chain of events:
ic_cdk::storage::stable_save
, which in turn callscandid::write_args
, which constructs an IDLBuilder and serializes the data onto it.Vec<u8>
with 0 capacity.Part of https://dfinity.atlassian.net/browse/SDK-1827
How Has This Been Tested?
Create a new project and add the portal's data to its frontend canister. I ended up reading the data from the portal canister.
In one shell, run the following:
In another shell, with the dfx under test on the PATH, run the following:
Checklist: