Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error message when asset wasm is not allowlisted in playground #4035

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Dec 10, 2024

Description

When we forget to allowlist the latest frontend canister wasm to the playground backend the error message is incomprehensible to users:

Error: Failed while trying to deploy canisters.
Caused by: Failed while trying to install all canisters.
Caused by: Failed to install wasm module to canister 'ii_integration_frontend'.
Caused by: install failed
Caused by: The replica returned a rejection error: reject code CanisterReject, reject message IC0503: Error from Canister ozk6r-tyaaa-aaaab-qab4a-cai: Canister called `ic0.trap` with message: Wasm is not whitelisted.
Consider gracefully handling failures from this canister or altering the canister to handle exceptions. See documentation: http://internetcomputer.org/docs/current/references/execution-errors#trapped-explicitly, error code None

New error message:

Error: Failed while trying to deploy canisters.
Caused by: Failed while trying to install all canisters.
Caused by: Failed to install wasm module to canister 'hello_frontend'.
Error explanation:
The frontend canister wasm needs to be allowlisted in the playground but it isn't. This is a mistake in the release process.
How to resolve the error:
Please report this on forum.dfinity.org and mention your dfx version. You can get the version with 'dfx --version'.

The removed .context("install failed") did not add any useful info.

Fixes SDKTG-418

How Has This Been Tested?

Tested manually.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 requested a review from a team as a code owner December 10, 2024 15:21
@sesi200 sesi200 merged commit a6a137d into master Dec 11, 2024
296 checks passed
@sesi200 sesi200 deleted the severin/not-allowlisted-frontend-canister-error branch December 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants