chore(docs): add manual allowlist check to promote runbook #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwshang
previously approved these changes
Dec 10, 2024
ericswanson-dfinity
requested changes
Dec 11, 2024
| @@ -114,6 +114,8 @@ Modify `DFX_VERSION` in these two files: | |||
|
|
|||
| ## Stage 5: Promote the release - day 4 | |||
|
|
|||
| * Precondition: Make sure `dfx deploy --playground` works with a project created by `dfx new`. This makes sure that the asset canister wasm is properly allowlisted in the playground backend. | |||
There was a problem hiding this comment.
This means merging the motoko-playground PR first (which is found in the following step, "Merge PRs"). So as written, this precondition can never succeed. We should update this stage to first merge the motoko-playground PR.
There was a problem hiding this comment.
Good point. I adjusted stage 4 to merge the Motoko playground PR as merging and deploying that PR does not change any public documentation or default behavior
ericswanson-dfinity
previously approved these changes
Dec 11, 2024
ericswanson-dfinity
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had it happen multiple times that we promoted a dfx version where
dfx deploy --playgrounddoes not work because the updated allowlist was not deployed in time. With this new check we can make sure this doesn't happen again.